This driver doesn't set all members of mbus format field when the
VIDIOC_SUBDEV_{S,G}_FMT ioctls are called.

This is detected by v4l2-compliance.

Cc: Enrico Scholz <enrico.sch...@sigma-chemnitz.de>
Cc: Michael Grzeschik <m.grzesc...@pengutronix.de>
Cc: Marco Felsch <m.fel...@pengutronix.de>
Cc: Sakari Ailus <sakari.ai...@linux.intel.com>
Cc: Mauro Carvalho Chehab <mche...@kernel.org>
Signed-off-by: Akinobu Mita <akinobu.m...@gmail.com>
---
* No changes from v1

 drivers/media/i2c/mt9m111.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/media/i2c/mt9m111.c b/drivers/media/i2c/mt9m111.c
index eb5bf71..e758b4d 100644
--- a/drivers/media/i2c/mt9m111.c
+++ b/drivers/media/i2c/mt9m111.c
@@ -543,6 +543,9 @@ static int mt9m111_get_fmt(struct v4l2_subdev *sd,
        mf->code        = mt9m111->fmt->code;
        mf->colorspace  = mt9m111->fmt->colorspace;
        mf->field       = V4L2_FIELD_NONE;
+       mf->ycbcr_enc   = V4L2_YCBCR_ENC_DEFAULT;
+       mf->quantization        = V4L2_QUANTIZATION_DEFAULT;
+       mf->xfer_func   = V4L2_XFER_FUNC_DEFAULT;
 
        return 0;
 }
@@ -670,6 +673,10 @@ static int mt9m111_set_fmt(struct v4l2_subdev *sd,
 
        mf->code = fmt->code;
        mf->colorspace = fmt->colorspace;
+       mf->field       = V4L2_FIELD_NONE;
+       mf->ycbcr_enc   = V4L2_YCBCR_ENC_DEFAULT;
+       mf->quantization        = V4L2_QUANTIZATION_DEFAULT;
+       mf->xfer_func   = V4L2_XFER_FUNC_DEFAULT;
 
        if (format->which == V4L2_SUBDEV_FORMAT_TRY) {
                cfg->try_fmt = *mf;
-- 
2.7.4

Reply via email to