Hi Maxime, I love your patch! Yet something to improve:
[auto build test ERROR on phy/next] [cannot apply to v4.20-rc5] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Maxime-Ripard/phy-Add-MIPI-D-PHY-mode/20181208-034527 base: https://git.kernel.org/pub/scm/linux/kernel/git/kishon/linux-phy.git next config: i386-randconfig-s0-12051035 (attached as .config) compiler: gcc-6 (Debian 6.4.0-9) 6.4.0 20171026 reproduce: # save the attached .config to linux build tree make ARCH=i386 All errors (new ones prefixed by >>): drivers/gpu/drm/bridge/cdns-dsi.o: In function `cdns_dsi_check_conf': >> drivers/gpu/drm/bridge/cdns-dsi.c:612: undefined reference to >> `phy_mipi_dphy_get_default_config' vim +612 drivers/gpu/drm/bridge/cdns-dsi.c 596 597 static int cdns_dsi_check_conf(struct cdns_dsi *dsi, 598 const struct drm_display_mode *mode, 599 struct cdns_dsi_cfg *dsi_cfg, 600 bool mode_valid_check) 601 { 602 struct cdns_dsi_output *output = &dsi->output; 603 struct phy_configure_opts_mipi_dphy *phy_cfg = &output->phy_opts.mipi_dphy; 604 unsigned long dsi_hss_hsa_hse_hbp; 605 unsigned int nlanes = output->dev->lanes; 606 int ret; 607 608 ret = cdns_dsi_mode2cfg(dsi, mode, dsi_cfg, mode_valid_check); 609 if (ret) 610 return ret; 611 > 612 phy_mipi_dphy_get_default_config(mode->crtc_clock * 1000, 613 mipi_dsi_pixel_format_to_bpp(output->dev->format), 614 nlanes, phy_cfg); 615 616 ret = cdns_dsi_adjust_phy_config(dsi, dsi_cfg, phy_cfg, mode, mode_valid_check); 617 if (ret) 618 return ret; 619 620 ret = phy_validate(dsi->dphy, PHY_MODE_MIPI_DPHY, 0, &output->phy_opts); 621 if (ret) 622 return ret; 623 624 dsi_hss_hsa_hse_hbp = dsi_cfg->hbp + DSI_HBP_FRAME_OVERHEAD; 625 if (output->dev->mode_flags & MIPI_DSI_MODE_VIDEO_SYNC_PULSE) 626 dsi_hss_hsa_hse_hbp += dsi_cfg->hsa + DSI_HSA_FRAME_OVERHEAD; 627 628 /* 629 * Make sure DPI(HFP) > DSI(HSS+HSA+HSE+HBP) to guarantee that the FIFO 630 * is empty before we start a receiving a new line on the DPI 631 * interface. 632 */ 633 if ((u64)phy_cfg->hs_clk_rate * mode_to_dpi_hfp(mode) * nlanes < 634 (u64)dsi_hss_hsa_hse_hbp * 635 (mode_valid_check ? mode->clock : mode->crtc_clock) * 1000) 636 return -EINVAL; 637 638 return 0; 639 } 640 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
