On Mon, Nov 12, 2018 at 01:35:12AM +0100, Lubomir Rintel wrote:
> Add Marvell MMP2 camera host interface.
> 
> Signed-off-by: Lubomir Rintel <lkund...@v3.sk>
> ---
>  .../bindings/media/marvell,mmp2-ccic.txt      | 30 +++++++++++++++++++
>  1 file changed, 30 insertions(+)
>  create mode 100644 
> Documentation/devicetree/bindings/media/marvell,mmp2-ccic.txt
> 
> diff --git a/Documentation/devicetree/bindings/media/marvell,mmp2-ccic.txt 
> b/Documentation/devicetree/bindings/media/marvell,mmp2-ccic.txt
> new file mode 100644
> index 000000000000..a9c536e58dda
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/marvell,mmp2-ccic.txt
> @@ -0,0 +1,30 @@
> +Marvell MMP2 camera host interface
> +
> +Required properties:
> + - compatible: Should be "marvell,mmp2-ccic"
> + - reg: register base and size
> + - interrupts: the interrupt number
> + - any required generic properties defined in video-interfaces.txt
> +
> +Optional properties:
> + - clocks: input clock (see clock-bindings.txt)
> + - clock-output-names: should contain the name of the clock driving the
> +                       sensor master clock MCLK

Missing #clock-cells and clock-names.

How many ports and endpoints also needs to be documented.

> +
> +Example:
> +
> +     camera0: camera@d420a000 {
> +             compatible = "marvell,mmp2-ccic";
> +             reg = <0xd420a000 0x800>;
> +             interrupts = <42>;
> +             clocks = <&soc_clocks MMP2_CLK_CCIC0>;
> +             clock-names = "CCICAXICLK";
> +             #clock-cells = <0>;
> +             clock-output-names = "mclk";
> +
> +             port {
> +                     camera0_0: endpoint {
> +                             remote-endpoint = <&ov7670_0>;
> +                     };
> +             };
> +     };
> -- 
> 2.19.1
> 

Reply via email to