On 09/13/2018 04:53 PM, Mauro Carvalho Chehab wrote:
> Em Thu, 13 Sep 2018 16:40:47 +0200
> Maxime Ripard <[email protected]> escreveu:
>
>
>> --- a/drivers/staging/media/sunxi/cedrus/cedrus_video.c
>> +++ b/drivers/staging/media/sunxi/cedrus/cedrus_video.c
>> @@ -82,10 +82,7 @@ static struct cedrus_format *cedrus_find_format(u32
>> pixelformat, u32 directions,
>> static bool cedrus_check_format(u32 pixelformat, u32 directions,
>> unsigned int capabilities)
>> {
>> - struct cedrus_format *fmt = cedrus_find_format(pixelformat, directions,
>> - capabilities);
>> -
>> - return fmt != NULL;
>> + return cedrus_find_format(pixelformat, directions, capabilities);
>> }
>
> Hmm... just occurred to me... Why do you need this? I mean, you
> could simply do something like:
>
> $ git filter-branch -f --tree-filter 'for i in $(git grep -l
> cedrus_check_format); do \
> sed -E s,\\bcedrus_check_format\\b,cedrus_find_format,g -i $i; done '
> origin/master..
>
> (or just do a sed -E s,\\bcedrus_check_format\\b,cedrus_find_format,g as
> a separate patch)
>
> and get rid of cedrus_check_format() for good.
That looks like a nice follow-up patch. It's a staging driver, it doesn't
have to be perfect.
I'll prepare a pull request tomorrow.
Regards,
Hans
