In order to prepare for allowing drivers to set the defaults for a given
bus, make zeroing the struct conditional based on detecting the bus.
All callers now set the bus type to zero which allows only zeroing the
remaining bus union.

Signed-off-by: Sakari Ailus <sakari.ai...@linux.intel.com>
---
 drivers/media/v4l2-core/v4l2-fwnode.c | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/drivers/media/v4l2-core/v4l2-fwnode.c 
b/drivers/media/v4l2-core/v4l2-fwnode.c
index ba51c1ead314..6c5a76442667 100644
--- a/drivers/media/v4l2-core/v4l2-fwnode.c
+++ b/drivers/media/v4l2-core/v4l2-fwnode.c
@@ -325,6 +325,12 @@ static int __v4l2_fwnode_endpoint_parse(struct 
fwnode_handle *fwnode,
        u32 bus_type = 0;
        int rval;
 
+       if (vep->bus_type == V4L2_MBUS_UNKNOWN) {
+               /* Zero fields from bus union to until the end */
+               memset(&vep->bus, 0,
+                      sizeof(*vep) - offsetof(typeof(*vep), bus));
+       }
+
        pr_debug("===== begin V4L2 endpoint properties\n");
 
        /*
@@ -333,10 +339,6 @@ static int __v4l2_fwnode_endpoint_parse(struct 
fwnode_handle *fwnode,
         */
        memset(&vep->base, 0, sizeof(vep->base));
 
-       /* Zero fields from bus_type to until the end */
-       memset(&vep->bus_type, 0, sizeof(*vep) -
-              offsetof(typeof(*vep), bus_type));
-
        fwnode_property_read_u32(fwnode, "bus-type", &bus_type);
 
        switch (bus_type) {
-- 
2.11.0

Reply via email to