Acked-by: Steve Longerbeam <steve_longerb...@mentor.com>
On 05/14/2018 06:13 AM, Hans Verkuil wrote:
From: Hans Verkuil <hans.verk...@cisco.com> drivers/staging/media/imx/imx-media-capture.c: In function 'vidioc_querycap': drivers/staging/media/imx/imx-media-capture.c:76:2: warning: 'strncpy' output truncated copying 15 bytes from a string of length 17 [-Wstringop-truncation] strncpy(cap->driver, "imx-media-capture", sizeof(cap->driver) - 1); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Signed-off-by: Hans Verkuil <hans.verk...@cisco.com> Cc: Steve Longerbeam <slongerb...@gmail.com> Cc: Philipp Zabel <p.za...@pengutronix.de> --- drivers/staging/media/imx/imx-media-capture.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/media/imx/imx-media-capture.c b/drivers/staging/media/imx/imx-media-capture.c index 0ccabe04b0e1..4e3fdf8aeef5 100644 --- a/drivers/staging/media/imx/imx-media-capture.c +++ b/drivers/staging/media/imx/imx-media-capture.c @@ -73,8 +73,8 @@ static int vidioc_querycap(struct file *file, void *fh, { struct capture_priv *priv = video_drvdata(file);- strncpy(cap->driver, "imx-media-capture", sizeof(cap->driver) - 1);- strncpy(cap->card, "imx-media-capture", sizeof(cap->card) - 1); + strlcpy(cap->driver, "imx-media-capture", sizeof(cap->driver)); + strlcpy(cap->card, "imx-media-capture", sizeof(cap->card)); snprintf(cap->bus_info, sizeof(cap->bus_info), "platform:%s", priv->src_sd->name);
