Hi Akinobu, On Mon, Apr 16, 2018 at 11:51:44AM +0900, Akinobu Mita wrote: > Set the V4L2_SUBDEV_FL_HAS_DEVNODE flag for the subdevice so that the > subdevice device node is created. > > Cc: Jacopo Mondi <jacopo+rene...@jmondi.org> > Cc: Laurent Pinchart <laurent.pinch...@ideasonboard.com> > Cc: Hans Verkuil <hans.verk...@cisco.com> > Cc: Sakari Ailus <sakari.ai...@linux.intel.com> > Cc: Mauro Carvalho Chehab <mche...@s-opensource.com> > Signed-off-by: Akinobu Mita <akinobu.m...@gmail.com> > --- > * v2 > - No changes > > drivers/media/i2c/ov772x.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/media/i2c/ov772x.c b/drivers/media/i2c/ov772x.c > index 8badd6f..188f2f1 100644 > --- a/drivers/media/i2c/ov772x.c > +++ b/drivers/media/i2c/ov772x.c > @@ -1287,6 +1287,7 @@ static int ov772x_probe(struct i2c_client *client, > priv->info = client->dev.platform_data; > > v4l2_i2c_subdev_init(&priv->subdev, client, &ov772x_subdev_ops); > + priv->subdev.flags |= V4L2_SUBDEV_FL_HAS_DEVNODE;
Could you move this patch as the last in the set, so that you're enabling the sub-device interface only when all the changes to support it are actually there? > v4l2_ctrl_handler_init(&priv->hdl, 3); > v4l2_ctrl_new_std(&priv->hdl, &ov772x_ctrl_ops, > V4L2_CID_VFLIP, 0, 1, 1, 0); -- Kind regards, Sakari Ailus sakari.ai...@linux.intel.com
