There's a false positive warning there:
        drivers/media/i2c/tda9840.c:79 tda9840_status() error: uninitialized 
symbol 'byte'.

Change the code to match our coding style, in order to fix it.

Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com>
---
 drivers/media/i2c/tda9840.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/media/i2c/tda9840.c b/drivers/media/i2c/tda9840.c
index f31e659588ac..0dd6ff3e6201 100644
--- a/drivers/media/i2c/tda9840.c
+++ b/drivers/media/i2c/tda9840.c
@@ -68,11 +68,15 @@ static void tda9840_write(struct v4l2_subdev *sd, u8 reg, 
u8 val)
 static int tda9840_status(struct v4l2_subdev *sd)
 {
        struct i2c_client *client = v4l2_get_subdevdata(sd);
+       int rc;
        u8 byte;
 
-       if (1 != i2c_master_recv(client, &byte, 1)) {
+       rc = i2c_master_recv(client, &byte, 1);
+       if (rc != 1) {
                v4l2_dbg(1, debug, sd,
                        "i2c_master_recv() failed\n");
+               if (rc < 0)
+                       return rc;
                return -EIO;
        }
 
-- 
2.14.3

Reply via email to