On Mon, Jan 29, 2018 at 12:13:14PM -0200, Mauro Carvalho Chehab wrote: > Em Mon, 29 Jan 2018 11:47:42 +0200 > Sakari Ailus <sakari.ai...@iki.fi> escreveu: > > > > > + compat_caddr_t p; > > > + > > > if (copy_to_user(&up->w, &kp->w, sizeof(kp->w)) || > > > put_user(kp->field, &up->field) || > > > put_user(kp->chromakey, &up->chromakey) || > > > put_user(kp->clipcount, &up->clipcount) || > > > put_user(kp->global_alpha, &up->global_alpha)) > > > return -EFAULT; > > > > One more newline here? > > Why? A new line here would be weird.
There are two if clauses that are unrelated. I'd say it improves readability to separate them. That said, this isn't an exact science, so I leave this up to Hans to decide. -- Sakari Ailus e-mail: sakari.ai...@iki.fi
