On Mon, Dec 25, 2017 at 10:11:24PM +0800, Shunqian Zheng wrote:
> Add device tree binding documentation for the OV5695 sensor.
> 
> Signed-off-by: Shunqian Zheng <zhen...@rock-chips.com>
> ---
>  .../devicetree/bindings/media/i2c/ov5695.txt       | 38 
> ++++++++++++++++++++++
>  1 file changed, 38 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/media/i2c/ov5695.txt
> 
> diff --git a/Documentation/devicetree/bindings/media/i2c/ov5695.txt 
> b/Documentation/devicetree/bindings/media/i2c/ov5695.txt
> new file mode 100644
> index 0000000..ed27eb1
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/i2c/ov5695.txt
> @@ -0,0 +1,38 @@
> +* Omnivision OV5695 MIPI CSI-2 sensor
> +
> +Required Properties:
> +- compatible: should be "ovti,ov5695"
> +- clocks: reference to the 24M xvclk input clock.
> +- clock-names: should be "xvclk".
> +- dovdd-supply: Digital I/O voltage supply, 1.8 volts
> +- avdd-supply: Analog voltage supply, 2.8 volts
> +- dvdd-supply: Digital core voltage supply, 1.2 volts
> +- reset-gpios: Low active reset gpio
> +
> +The device node must contain one 'port' child node for its digital output
> +video port, in accordance with the video interface bindings defined in
> +Documentation/devicetree/bindings/media/video-interfaces.txt.
> +
> +Example:
> +&i2c1 {

Presumably, i2c1 is your I2C controller, so you are missing a child node 
here: camera-sensor@36

With that,

Reviewed-by: Rob Herring <r...@kernel.org>

> +     compatible = "ovti,ov5695";
> +     reg = <0x36>;
> +     pinctrl-names = "default";
> +     pinctrl-0 = <&clk_24m_cam &wcam_rst>;
> +
> +     clocks = <&cru SCLK_TESTCLKOUT1>;
> +     clock-names = "xvclk";
> +
> +     avdd-supply = <&pp2800_cam>;
> +     dvdd-supply = <&pp1250_cam>;
> +     dovdd-supply = <&pp1800>;
> +
> +     reset-gpios = <&gpio2 5 GPIO_ACTIVE_LOW>;
> +
> +     port {
> +             wcam_out: endpoint {
> +                     remote-endpoint = <&mipi_in_wcam>;
> +                     data-lanes = <1 2>;
> +             };
> +     };
> +};
> -- 
> 1.9.1
> 

Reply via email to