On 06/16/2017 01:39 AM, Gustavo Padovan wrote: > From: Gustavo Padovan <gustavo.pado...@collabora.com> > > Call v4l2_ctrl_subscribe_event to subscribe to more events supported by > v4l. > > Signed-off-by: Gustavo Padovan <gustavo.pado...@collabora.com> > --- > drivers/media/usb/uvc/uvc_v4l2.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/usb/uvc/uvc_v4l2.c > b/drivers/media/usb/uvc/uvc_v4l2.c > index 3e7e283..dfa0ccd 100644 > --- a/drivers/media/usb/uvc/uvc_v4l2.c > +++ b/drivers/media/usb/uvc/uvc_v4l2.c > @@ -1240,7 +1240,7 @@ static int uvc_ioctl_subscribe_event(struct v4l2_fh *fh, > case V4L2_EVENT_CTRL: > return v4l2_event_subscribe(fh, sub, 0, &uvc_ctrl_sub_ev_ops); > default: > - return -EINVAL; > + return v4l2_ctrl_subscribe_event(fh, sub);
This looks incorrect. With this change driver will be subscribing to all v4l2 events? Is this the intent? > } > } > > thanks, -- Shuah
