Em Mon, 10 Apr 2017 21:26:40 +0200
Hans Verkuil <hverk...@xs4all.nl> escreveu:

> From: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com>
> 
> The histogram common code will be used to implement support for both the
> HGO and HGT histogram computation engines.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com>
> ---
>  drivers/media/platform/Kconfig           |   1 +
>  drivers/media/platform/vsp1/Makefile     |   1 +
>  drivers/media/platform/vsp1/vsp1_histo.c | 646 
> +++++++++++++++++++++++++++++++
>  drivers/media/platform/vsp1/vsp1_histo.h |  84 ++++
>  4 files changed, 732 insertions(+)
>  create mode 100644 drivers/media/platform/vsp1/vsp1_histo.c
>  create mode 100644 drivers/media/platform/vsp1/vsp1_histo.h

> diff --git a/drivers/media/platform/vsp1/vsp1_histo.c 
> b/drivers/media/platform/vsp1/vsp1_histo.c
> new file mode 100644
> index 000000000000..afab77cf4fa5
> --- /dev/null
> +++ b/drivers/media/platform/vsp1/vsp1_histo.c

...

> +     crop = vsp1_entity_get_pad_selection(&histo->entity, config, sel->pad,
> +                                          V4L2_SEL_TGT_CROP);
> +
> +     /*
> +      * Clamp the width and height to acceptable values first and then
> +      * compute the closest rounded dividing ratio.
> +      *
> +      * Ratio        Rounded ratio
> +      * --------------------------
> +      * [1.0 1.5[    1

Nitpick:

        1.0 1.5]        1

Thanks,
Mauro

Reply via email to