On Thu, Apr 06, 2017 at 03:55:29PM +0200, Philipp Zabel wrote:
> +
> +     /* Retain current field setting as default */
> +     if (sdformat->format.field == V4L2_FIELD_ANY)
> +             sdformat->format.field = fmt->field;
> +
> +     /* Retain current colorspace setting as default */
> +     if (sdformat->format.colorspace == V4L2_COLORSPACE_DEFAULT) {
> +             sdformat->format.colorspace = fmt->colorspace;
> +             if (sdformat->format.xfer_func == V4L2_XFER_FUNC_DEFAULT)
> +                     sdformat->format.xfer_func = fmt->xfer_func;
> +             if (sdformat->format.ycbcr_enc == V4L2_YCBCR_ENC_DEFAULT)
> +                     sdformat->format.ycbcr_enc = fmt->ycbcr_enc;
> +             if (sdformat->format.quantization == V4L2_QUANTIZATION_DEFAULT)
> +                     sdformat->format.quantization = fmt->quantization;
> +     } else {
> +             if (sdformat->format.xfer_func == V4L2_XFER_FUNC_DEFAULT) {
> +                     sdformat->format.xfer_func =
> +                             V4L2_MAP_XFER_FUNC_DEFAULT(
> +                                             sdformat->format.colorspace);
> +             }
> +             if (sdformat->format.ycbcr_enc == V4L2_YCBCR_ENC_DEFAULT) {
> +                     sdformat->format.ycbcr_enc =
> +                             V4L2_MAP_YCBCR_ENC_DEFAULT(
> +                                             sdformat->format.colorspace);
> +             }
> +             if (sdformat->format.quantization == V4L2_QUANTIZATION_DEFAULT) 
> {
> +                     sdformat->format.quantization =
> +                             V4L2_MAP_QUANTIZATION_DEFAULT(
> +                                             cc->cs != IPUV3_COLORSPACE_YUV,
> +                                             sdformat->format.colorspace,
> +                                             sdformat->format.ycbcr_enc);
> +             }
> +     }

Would it make sense for this to be a helper function?

-- 
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.

Reply via email to