On Fri, Mar 03, 2017 at 07:33:43AM -0300, Mauro Carvalho Chehab wrote: > tveeprom_hauppauge_analog() used to need the I2C adapter in > order to print debug messages. As it now uses pr_foo() facilities, > this is not needed anymore. > > So, get rid of it.
Hi Mauro, Thanks for CCing :) > diff --git a/drivers/media/usb/em28xx/em28xx-cards.c > b/drivers/media/usb/em28xx/em28xx-cards.c > index 5f90d0899a45..5f80a1b2fb8c 100644 > --- a/drivers/media/usb/em28xx/em28xx-cards.c > +++ b/drivers/media/usb/em28xx/em28xx-cards.c > @@ -2974,8 +2974,7 @@ static void em28xx_card_setup(struct em28xx *dev) > #endif > /* Call first TVeeprom */ > > - dev->i2c_client[dev->def_i2c_bus].addr = 0xa0 >> 1; > - tveeprom_hauppauge_analog(&dev->i2c_client[dev->def_i2c_bus], > &tv, dev->eedata); > + tveeprom_hauppauge_analog(&tv, dev->eedata); Are we sure no other code relies on dev->i2c_client[dev->def_i2c_bus].addr being set here? I am completely not familiar with this driver, that's why I'm asking.
