Hi Philipp,

On Wed, Mar 01, 2017 at 04:36:25PM +0100, Philipp Zabel wrote:
> Recently, an unfinished patch was merged that added a third entry to the
> beginning of the array of firmware locations without changing the code
> to also look at the third element, thus pushing an old firmware location
> off the list.
> 
> Fixes: 8af7779f3cbc ("[media] coda: add Freescale firmware compatibility 
> location")
> Cc: Baruch Siach <bar...@tkos.co.il>
> Signed-off-by: Philipp Zabel <p.za...@pengutronix.de>

Thanks for cleaning up after me.

Acked-by: Baruch Siach <bar...@tkos.co.il>

[snip]

> -     if (dev->firmware == 1) {
> +     if (dev->firmware > 0) {
>               /*
>                * Since we can't suppress warnings for failed asynchronous
>                * firmware requests, report that the fallback firmware was

I still think this is ugly, though.

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - bar...@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -

Reply via email to