Hi,

do you know any reason (i.e. a special device needs this) why switch to
register page 0 is done twice in the setcolors() function of pac7311?

I removed the redundant page switch and my Labtec Webcam 2200 still
behaves correctly when I change the "Saturation" control.

Regards,

        Márton Németh

---
From: Márton Németh <nm...@freemail.hu>

Remove redundant register page switching to page 0 when changing the
color control.

The change was tested with Labtec Webcam 2200 (USB ID: 093a:2626).

Signed-off-by: Márton Németh <nm...@freemail.hu>
---
diff -upr d/drivers/media/video/gspca/pac7311.c 
e/drivers/media/video/gspca/pac7311.c
--- d/drivers/media/video/gspca/pac7311.c       2009-10-03 09:02:31.000000000 
+0200
+++ e/drivers/media/video/gspca/pac7311.c       2009-10-03 16:23:37.000000000 
+0200
@@ -579,7 +579,6 @@ static void setcolors(struct gspca_dev *
        reg_w(gspca_dev, 0xff, 0x03);   /* page 3 */
        reg_w(gspca_dev, 0x11, 0x01);
        reg_w(gspca_dev, 0xff, 0x00);   /* page 0 */
-       reg_w(gspca_dev, 0xff, 0x00);   /* page 0 */
        for (i = 0; i < 9; i++) {
                v = a[i] * sd->colors / COLOR_MAX + b[i];
                reg_w(gspca_dev, 0x0f + 2 * i, (v >> 8) & 0x07);
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to