Re: [PATCH 01/22] [media] v4l2-async: move code out of v4l2_async_notifier_register into v4l2_async_test_nofity_all

[Philipp Zabel]

Am Freitag, den 07.10.2016, 18:30 +0200 schrieb Marek Vasut:
> On 10/07/2016 06:00 PM, Philipp Zabel wrote:
> > This will be reused in the following patch to catch already registered,
> > newly added asynchronous subdevices from v4l2_async_register_subdev.
> > 
> > Signed-off-by: Philipp Zabel <p.za...@pengutronix.de>
> > ---
> >  drivers/media/v4l2-core/v4l2-async.c | 38 
> > +++++++++++++++++++++---------------
> >  1 file changed, 22 insertions(+), 16 deletions(-)
> > 
> > diff --git a/drivers/media/v4l2-core/v4l2-async.c 
> > b/drivers/media/v4l2-core/v4l2-async.c
> > index 5bada20..c4f1930 100644
> > --- a/drivers/media/v4l2-core/v4l2-async.c
> > +++ b/drivers/media/v4l2-core/v4l2-async.c
> > @@ -134,11 +134,31 @@ static void v4l2_async_cleanup(struct v4l2_subdev *sd)
> >     sd->dev = NULL;
> >  }
> >  
> > +static int v4l2_async_test_notify_all(struct v4l2_async_notifier *notifier)
> > +{
> > +   struct v4l2_subdev *sd, *tmp;
> > +
> > +   list_for_each_entry_safe(sd, tmp, &subdev_list, async_list) {
> > +           struct v4l2_async_subdev *asd;
> > +           int ret;
> > +
> > +           asd = v4l2_async_belongs(notifier, sd);
> > +           if (!asd)
> > +                   continue;
> > +
> > +           ret = v4l2_async_test_notify(notifier, sd, asd);
> > +           if (ret < 0)
> > +                   return ret;
> > +   }
> > +
> > +   return 0;
> > +}
> > +
> >  int v4l2_async_notifier_register(struct v4l2_device *v4l2_dev,
> >                              struct v4l2_async_notifier *notifier)
> >  {
> > -   struct v4l2_subdev *sd, *tmp;
> >     struct v4l2_async_subdev *asd;
> > +   int ret;
> >     int i;
> >  
> >     if (!notifier->num_subdevs || notifier->num_subdevs > V4L2_MAX_SUBDEVS)
> > @@ -171,23 +191,9 @@ int v4l2_async_notifier_register(struct v4l2_device 
> > *v4l2_dev,
> >     /* Keep also completed notifiers on the list */
> >     list_add(&notifier->list, &notifier_list);
> >  
> > -   list_for_each_entry_safe(sd, tmp, &subdev_list, async_list) {
> > -           int ret;
> > -
> > -           asd = v4l2_async_belongs(notifier, sd);
> > -           if (!asd)
> > -                   continue;
> > -
> > -           ret = v4l2_async_test_notify(notifier, sd, asd);
> > -           if (ret < 0) {
> > -                   mutex_unlock(&list_lock);
> > -                   return ret;
> > -           }
> > -   }
> 
> Shouldn't you call ret = v4l2_async_test_notify_all() here now instead ?

Absolutely, thanks. I've lost this in a rebase and the problem got
hidden by patch 2 replacing it again.

regards
Philipp

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html