On Wednesday 26 August 2009 22:06:20 Mauro Carvalho Chehab wrote:
> Em Wed, 26 Aug 2009 21:35:59 +0200
> Hans Verkuil <hverk...@xs4all.nl> escreveu:
>
> > On Wednesday 26 August 2009 21:16:53 Mauro Carvalho Chehab wrote:
> > > Em Sun, 16 Aug 2009 15:24:51 +0200
> > > Hans Verkuil <hverk...@xs4all.nl> escreveu:
> > >
> > > > Hi Mauro,
> > > >
> > > > Please pull from http://www.linuxtv.org/hg/~hverkuil/v4l-dvb for the
> > > > following:
> > >
> > > > - v4l2-spec: document the new string control type.
> > >
> > > <revnumber>0.26</revnumber>
> > > - <date>2009-06-15</date>
> > > + <date>2009-07-23</date>
> > >
> > > Hmm... No. Please create a new revision entry for it.
> >
> > Why? IMHO the revision only changes for each new kernel release. The spec
> > documents the V4L2 API as is appears in a certain kernel. It's similar in
> > that
> > respect to the kernel's version number: that also only changes with each new
> > kernel release. And furthermore, that's the way the version number was
> > handled
> > in the past as well.
> >
> > I did toy with the idea in the past to bump this version number to be in
> > sync
> > with the kernel: i.e. since this spec documents the upcoming 2.6.32 kernel
> > the
> > version should be 0.32 as well. That makes the link between spec and kernel
> > more explicit.
>
> Hmm... This is a good idea, but then, IMO, the better is to just jump the API
> version to 2.32 - or - even better - to 2.6.32. This will avoid any further
> sync issues in the future.
I think tracking the kernel version number (i.e. 2.6.32) is a good idea.
>
> Anyway, we had several changes at the spec between the last version and the
> 2.6.32 version (at least 3 of them having a revision increment).
>
> >
> > > + <entry>>=0</entry>
> > > + <entry>>=1</entry>
> > > + <entry>>=0</entry>
> > >
> > > Hmm... is it valid to use ">" char outside a tag? maybe docbook may
> > > accept,
> > > but, IMHO, this is not recommended (or allowed) on XML specs. Anyway, it
> > > is
> > > probably better to use an escape sequence like > instead of > above as
> > > used on
> > > other parts of the document, or, even better: ≥ for greater or equal
> > > to.
> >
> > Good point, I'll update this.
> >
> > >
> > > > - v4l2-spec: Add documentation description for FM TX extended control
> > > > class
> > >
> > > There's also a missing revision tag for it. As both changes will be
> > > merged together,
> > > you can increment it by just one (to 0.29), provided that both changes
> > > are properly
> > > documented at the revision tag.
> > >
> > > Except for those, the series looks ok to my eyes.
> >
> > I'll wait for your clarification on the spec's version number and then I'll
> > make this final small change and post a new pull request.
>
> Hmm... I tried to reach you at IRC.
For future reference: I'm generally only on irc during working hours. If you
want to discuss something on irc in the evening then just mail me and I will
usually appear within 30-60 minutes as I tend to keep an eye on my email
during the evening.
> As you weren't there anymore, I've assumed
> you've already sleeping ;) As I want to finish the pending PULL requests
> today,
> I've merged it as-is (just removing the revision update hunk) and added a
> patch
> at the end of the series properly fixing the docs, and including the proper
> changes documentation at compat.sgml.
Excellent, I'm very glad to see this series merged. It was a lot of fun
working with Eduardo on this very first radio modulator and RDS encoder
driver! Eduardo, thank you for your hard work on this!
Regards,
Hans
--
Hans Verkuil - video4linux developer - sponsored by TANDBERG Telecom
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
