On Thu, 2009-03-05 at 13:34 +0200, Sakari Ailus wrote:
> Thanks for the comments, Alexey!
>
> Alexey Klimov wrote:
> >> +static int isp_probe(struct platform_device *pdev)
> >> +{
> >> + struct isp_device *isp;
> >> + int ret_err = 0;
> >> + int i;
> >> +
> >> + isp = kzalloc(sizeof(*isp), GFP_KERNEL);
> >> + if (!isp) {
> >> + dev_err(&pdev->dev, "could not allocate memory\n");
> >> + return -ENODEV;
> >
> > return -ENOMEM; ?
>
> Done.
>
> >> + }
> >> +
> >> + platform_set_drvdata(pdev, isp);
> >> +
> >> + isp->dev = &pdev->dev;
> >> +
> >> + for (i = 0; i <= OMAP3_ISP_IOMEM_CSI2PHY; i++) {
> >> + struct resource *mem;
> >> + /* request the mem region for the camera registers */
> >> + mem = platform_get_resource(pdev, IORESOURCE_MEM, i);
> >> + if (!mem) {
> >> + dev_err(isp->dev, "no mem resource?\n");
> >> + return -ENODEV;
> >
> > Maybe ENODEV is not apropriate here too..
>
> What else it could be? ENOENT comes to mind but I'm not sure it's
> significantly better.
ENODEV is okay, sorry.
--
Best regards, Klimov Alexey
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
