On Sat, 28 Feb 2009, Erik S. Beiser wrote:

> cx88: Add IR support to pcHDTV HD3000 & HD5500
>
> Signed-off-by: Erik S. Beiser <er...@bu.edu>
>
> ---
>
> Idea originally from http://www.pchdtv.com/forum/viewtopic.php?t=1529
> I made it into this small patch and added the HD3000 support also, which I 
> have  I've actually
> been using this for over a year, updating for new kernel versions.  I'm tired 
> of doing so,
> and would like to try and have it merged upstream -- I hope I got all the 
> patch-mechanics
> correct.  I just updated and tested it today on 2.6.28.7 vanilla.  Thanks.

You forgot a patch description.

Since neither the HD-3000 or HD-5500 came with a remote, and at least my
HD-3000 didn't even come with an IR receiver.  So I have to ask why
configuring the driver to work a remote you happened to have is any more
correct than configuring it to work a remote someone else happens to have?

This patch also causes these cards to generate 101 interrupts per second
per card, even when not in use.  That seems pretty costly for a card that
doesn't even come with an ir sensor.
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to