Hi Thierry, On Tuesday 20 January 2009, Thierry Merle wrote: > usb_make_path reports canonical bus info. Use it when reporting bus info > in VIDIOC_QUERYCAP. > > Signed-off-by: Thierry MERLE <thierry.me...@free.fr> > > diff -r 72ba48adaacd -r 43bb285afc52 > linux/drivers/media/video/uvc/uvc_v4l2.c --- > a/linux/drivers/media/video/uvc/uvc_v4l2.c Tue Jan 20 22:06:58 2009 +0100 > +++ b/linux/drivers/media/video/uvc/uvc_v4l2.c Tue Jan 20 22:13:45 2009 > +0100 @@ -494,8 +494,7 @@ > memset(cap, 0, sizeof *cap); > strncpy(cap->driver, "uvcvideo", sizeof cap->driver); > strncpy(cap->card, vdev->name, 32); > - strncpy(cap->bus_info, video->dev->udev->bus->bus_name, > - sizeof cap->bus_info); > + usb_make_path(video->dev->udev, cap->bus_info, > sizeof(cap->bus_info));
This overflows the 80 columns limit, could you please split the statement ? + usb_make_path(video->dev->udev, cap->bus_info, + sizeof(cap->bus_info)); > cap->version = DRIVER_VERSION_NUMBER; > if (video->streaming->type == V4L2_BUF_TYPE_VIDEO_CAPTURE) > cap->capabilities = V4L2_CAP_VIDEO_CAPTURE Apart from that, Acked-by: Laurent Pinchart <laurent.pinch...@skynet.be> and thanks for the patch. -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
