On Wed, 14 Jan 2009 08:52:09 -0600 (CST) Mike Isely <is...@isely.net> wrote:
> > Mauro: > > Please pull from http://linuxtv.org/hg/~mcisely/pvrusb2 for: > About this changeset: > - pvrusb2: Report device serial number in bus-info field Previously the V4L bus-info capability reported USB address, a fairly useless thing for anyone but a USB core maintainer (IMHO). This change replaces that information with the device's serial number if possible, or otherwise a unit number. Priority: normal Signed-off-by: Mike Isely <is...@pobox.com> --- a/linux/drivers/media/video/pvrusb2/pvrusb2-v4l2.c Wed Jan 14 01:24:20 2009 -0600 +++ b/linux/drivers/media/video/pvrusb2/pvrusb2-v4l2.c Wed Jan 14 01:30:53 2009 -0600 @@ -205,7 +205,7 @@ static long pvr2_v4l2_do_ioctl(struct fi struct v4l2_capability *cap = arg; memcpy(cap, &pvr_capability, sizeof(struct v4l2_capability)); - strlcpy(cap->bus_info,pvr2_hdw_get_bus_info(hdw), + strlcpy(cap->bus_info, pvr2_hdw_get_device_identifier(hdw), sizeof(cap->bus_info)); strlcpy(cap->card,pvr2_hdw_get_desc(hdw),sizeof(cap->card)); I can see some troubles here: 1) The bus info helps to identify the place where you'll find the device info at sysfs; 2) This is a V4L2 API non-compliance. All drivers should be compliant with the API; 3) If we all agree that bus_info doesn't matter at all and decide to change V4L2 API, we'll still have a big trouble: most devices don't have a serial number. The other patches are ok. Cheers, Mauro -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
