On 09/09/2026 21:00, Jakub Kicinski wrote:
> Setting a sysctl or a sysfs attribute for the duration of a test and
> putting the old value back has been open coded multiple times.
>
> We generally avoid creating library helpers but this one is very
> common, and the defer is a little tricky as using the same function
> for defer as the initial write leads to an infinite loop (not that
> I would ever make such mistake!)
>
> Some of the conversions are not identical, but arguably ctl_file_write()
> semantics are more correct.
>
> Signed-off-by: Jakub Kicinski <[email protected]>
> ---
> v2:
> - rebase
> - drop the irq.py change which wasn't identical
> v1: https://lore.kernel.org/[email protected]
>
> CC: [email protected]
> CC: [email protected]
> CC: [email protected]
> CC: [email protected]
> CC: [email protected]
> CC: [email protected]
> CC: [email protected]
> CC: [email protected]
> ---
> .../testing/selftests/drivers/net/gro_lib.py | 17 +++---------
> .../drivers/net/hw/devlink_rate_tc_bw.py | 5 ++--
> .../drivers/net/hw/lib/py/__init__.py | 4 +--
> .../selftests/drivers/net/hw/toeplitz.py | 10 +++----
> .../selftests/drivers/net/lib/py/__init__.py | 4 +--
> .../selftests/drivers/net/ring_reconfig.py | 26 ++++---------------
> .../testing/selftests/net/lib/py/__init__.py | 4 +--
> tools/testing/selftests/net/lib/py/utils.py | 22 ++++++++++++++++
> 8 files changed, 42 insertions(+), 50 deletions(-)
Reviewed-by: Nimrod Oren <[email protected]>
