On 06/03/2026 04:17, Jakub Kicinski wrote:
On Thu, 5 Mar 2026 00:06:23 +0100 Antonio Quartulli wrote:
.../selftests/net/ovpn/check_requirements.py | 47 +++++++++++++++++++
this file is not included in the Makefile, it should probably be under
TEST_FILES ? otherwise when tests are installed with make install this
file won't be copied
Right, will do.
+if has_listener_requirements; then
+ for p in $(seq 0 ${NUM_PEERS}); do
+ setup_listener ${p}
+ done
+fi
There should probably be an else branch which prints some kind of
echo "SKIP - requirements missing"
Your requirements.py script prints stuff but the output needs to
contain the word SKIP
If "has_listener_requirements" is false, the test script still goes on,
but it won't check the received netlink notification content.
So we're not really skipping the whole test, just one specific check
that requires extra tooling (which is normally found on all standard
distros).
Do you think we should rather SKIP the whole test so that we can easily
spot that something is missing?
Regards,
--
Antonio Quartulli
OpenVPN Inc.
