On Mon, Aug 11, 2025 at 04:13:32PM -0700, Jakub Kicinski wrote: > We need to use bracketed IPv6 addresses for socat. > > Signed-off-by: Jakub Kicinski <[email protected]> > --- > tools/testing/selftests/drivers/net/hw/devmem.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/drivers/net/hw/devmem.py > b/tools/testing/selftests/drivers/net/hw/devmem.py > index baa2f24240ba..0a2533a3d6d6 100755 > --- a/tools/testing/selftests/drivers/net/hw/devmem.py > +++ b/tools/testing/selftests/drivers/net/hw/devmem.py > @@ -24,7 +24,7 @@ from lib.py import ksft_disruptive > require_devmem(cfg) > > port = rand_port() > - socat = f"socat -u - > TCP{cfg.addr_ipver}:{cfg.addr}:{port},bind={cfg.remote_addr}:{port}" > + socat = f"socat -u - > TCP{cfg.addr_ipver}:{cfg.baddr}:{port},bind={cfg.remote_baddr}:{port}"
FWIW I had no idea socat supports bracketed v4 addresses (just to make sure this change won't break anything). A quick test I did locally shows it does. Reviewed-by: Joe Damato <[email protected]>
