On Fri, Aug 01, 2025 at 12:14:34PM +0100, Lorenzo Stoakes wrote: >On Fri, Aug 01, 2025 at 11:02:35AM +0200, David Hildenbrand wrote: >> On 01.08.25 10:54, Wei Yang wrote: >> > Currently all test cases are linked with thp_settings, while only 6 >> > out of 50+ targets rely on it. >> > >> > Instead of making thp_settings as a common dependency, link it only >> > when necessary. >> >> >> You don't state why we should care about that? I don't see how binary size >> is a problem, why do you think it is? > >Yeah overall I'm with David on this, I'd rather we keep things simple (so >you don't need to remember to link against this file) and just plonk all >the stuff you need to link to together in the Makefile.
I have thought about this, while current implementation do specify its necessary dependency for some target like uffd-common.c/pkey_util.c. So I thought we may keep the same style. > >It's not really a big deal when it comes to test stuff I don't think. > Yes, this is not a big deal in general. I come up with this idea because my test machine is too old. This change could same me some time during coding/debugging. >Cheers, Lorenzo -- Wei Yang Help you, Help me
