On Thu, Jul 3, 2025 at 3:39 AM Jakub Kicinski <[email protected]> wrote:
>

Hi Jakub,
Thanks a lot for your review!

> On Wed,  2 Jul 2025 10:42:49 +0000 Taehee Yoo wrote:
> > The devmem TCP requires the hds-thresh value to be 0, but it doesn't
> > change it automatically.
> > Therefore, make configure_headersplit() sets hds-thresh value to 0.
>
> I don't see any undoing of the configuration :(
> The selftest should leave the system in the state that it started.
> We should either add some code to undo at shutdown or (preferably)
> move the logic to the Python script where we can handle this more
> cleanly with defer().

Okay, I understand it.
I will fix this in the next version.

Thanks a lot!
Taehee Yoo

> --
> pw-bot: cr

Reply via email to