On Mon, 30 Jun 2025 15:51:11 +0000 Chia-Yu Chang (Nokia) wrote: > > > Thanks again for other comments again, and I will take actions in the > > > next version. > > > > > > As there is only one step marking in L-queue, so we still need two > > > WRITE_ONCE even two attributes (one for threshold in packets and one > > > in time) are used. > > > > > > When applying the step marking, we need to know either the computation > > > is based on the sojourn time or queue length. > > > > Let me ask again - why do you use WRITE_ONCE() at all if the > > modification takes the qdisc lock? Which reader are you afraid of > > racing with? > > This still needs 2 WRITE_ONCE even "step_thresh" (NLA_U32) and > "step_in_packtes" (NLA_FLAG) are replaced with "step_pkt_thresh" > (NLA_U32) and "step_time_thresh" (NLA_U32) - which was proposed in my > another email.
If you don't understand the question - ask for clarifications :/
