On Fri, May 30, 2025 at 06:58:00AM -0700, Jakub Kicinski wrote: > This reverts commit a571a9a1b120264e24b41eddf1ac5140131bfa84.
Please include human readable descriptions of things like commits and issues being discussed in e-mail in your mails, this makes them much easier for humans to read especially when they have no internet access. I do frequently catch up on my mail on flights or while otherwise travelling so this is even more pressing for me than just being about making things a bit easier to read. > The commit in question breaks kunit for older compilers: > $ gcc --version > gcc (GCC) 11.5.0 20240719 (Red Hat 11.5.0-5) > > $ ./tools/testing/kunit/kunit.py run --alltests --json --arch=x86_64 > Configuring KUnit Kernel ... > Regenerating .config ... > Populating config with: > $ make ARCH=x86_64 O=.kunit olddefconfig > ERROR:root:Not all Kconfig options selected in kunitconfig were in the > generated .config. > This is probably due to unsatisfied dependencies. > Missing: CONFIG_INIT_STACK_ALL_PATTERN=y This seems like there's a bigger issue here - this sort of thing will keep happening if you're running with older compilers and it's also going to be prevent the addition of any coverage that's specific to architectures. It would seem better to fix this by warning only and not erroring out, perhaps splitting the config fragments into must succeed and can be dropped sections.
signature.asc
Description: PGP signature
