On 05/06, Cosmin Ratiu wrote:
> __netdev_update_features() expects the netdevice to be ops-locked, but
> it gets called recursively on the lower level netdevices to sync their
> features, and nothing locks those.
> 
> This commit fixes that, with the assumption that it shouldn't be possible
> for both higher-level and lover-level netdevices to require the instance
> lock, because that would lead to lock dependency warnings.
> 
> Without this, playing with higher level (e.g. vxlan) netdevices on top
> of netdevices with instance locking enabled can run into issues:

Mentioning vxlan is a bit confusing here; it shouldn't let you flip lro (I
think). Which upper are you testing against?

Trying to understand if we can cover this case in the selftests.
netdevsim also doesn't expose F_LRO feature... (yet?)

Reply via email to