On Sun, 29 Sept 2024 at 08:00, Pedro Orlando <porla...@lkcamp.dev> wrote:
>
> From: Gabriela Bittencourt <gbittenco...@lkcamp.dev>
>
> Change utf8 kunit test filename and path to follow the style
> convention on Documentation/dev-tools/kunit/style.rst
>
> Co-developed-by: Pedro Orlando <porla...@lkcamp.dev>
> Signed-off-by: Pedro Orlando <porla...@lkcamp.dev>
> Co-developed-by: Danilo Pereira <dpere...@lkcamp.dev>
> Signed-off-by: Danilo Pereira <dpere...@lkcamp.dev>
> Signed-off-by: Gabriela Bittencourt <gbittenco...@lkcamp.dev>
> ---
This looks good to me. The only thing I'm not 100% sure about is
whether or not we want to move the .kunitconfig file into the tests/
directory. I'm leaning towards "yes", but we may want to update
kunit.py at some point to support automatically adding tests/ to the
search path for a .kunitconfig if this becomes a common enough
pattern.
Regardless, let's take this as-is.
Reviewed-by: David Gow <david...@google.com>
Cheers,
-- David
> fs/unicode/Makefile | 2 +-
> fs/unicode/{ => tests}/.kunitconfig | 0
> fs/unicode/{utf8-selftest.c => tests/utf8_kunit.c} | 0
> 3 files changed, 1 insertion(+), 1 deletion(-)
> rename fs/unicode/{ => tests}/.kunitconfig (100%)
> rename fs/unicode/{utf8-selftest.c => tests/utf8_kunit.c} (100%)
>
> diff --git a/fs/unicode/Makefile b/fs/unicode/Makefile
> index 37bbcbc628a1..d95be7fb9f6b 100644
> --- a/fs/unicode/Makefile
> +++ b/fs/unicode/Makefile
> @@ -4,7 +4,7 @@ ifneq ($(CONFIG_UNICODE),)
> obj-y += unicode.o
> endif
> obj-$(CONFIG_UNICODE) += utf8data.o
> -obj-$(CONFIG_UNICODE_NORMALIZATION_KUNIT_TEST) += utf8-selftest.o
> +obj-$(CONFIG_UNICODE_NORMALIZATION_KUNIT_TEST) += tests/utf8_kunit.o
>
> unicode-y := utf8-norm.o utf8-core.o
>
> diff --git a/fs/unicode/.kunitconfig b/fs/unicode/tests/.kunitconfig
> similarity index 100%
> rename from fs/unicode/.kunitconfig
> rename to fs/unicode/tests/.kunitconfig
> diff --git a/fs/unicode/utf8-selftest.c b/fs/unicode/tests/utf8_kunit.c
> similarity index 100%
> rename from fs/unicode/utf8-selftest.c
> rename to fs/unicode/tests/utf8_kunit.c
> --
> 2.34.1
>
