On Mon, Sep 30, 2024 at 07:55:08AM +0000, Tian, Kevin wrote:

> > +struct vfio_device_pasid_attach_iommufd_pt {
> > +   __u32   argsz;
> > +   __u32   flags;
> > +   __u32   pasid;
> > +   __u32   pt_id;
> > +};
> > +
> > +#define VFIO_DEVICE_PASID_ATTACH_IOMMUFD_PT        _IO(VFIO_TYPE,
> > VFIO_BASE + 21)
> 
> Not sure whether this was discussed before. Does it make sense
> to reuse the existing VFIO_DEVICE_ATTACH_IOMMUFD_PT
> by introducing a new pasid field and a new flag bit?

Maybe? I don't have a strong feeling either way.

There is somewhat less code if you reuse the ioctl at least

Jason

Reply via email to