From: Amit Cohen <amco...@nvidia.com>

The test runs "devlink reload" explicitly. Instead, it is better to use
devlink_reload() which waits for udev events to be processed. Do not sleep
after reload, as devlink_reload() blocks until all the netdevs are renamed.

Signed-off-by: Amit Cohen <amco...@nvidia.com>
Reviewed-by: Ido Schimmel <ido...@nvidia.com>
Signed-off-by: Petr Machata <pe...@nvidia.com>
---
 tools/testing/selftests/drivers/net/mlxsw/rtnetlink.sh | 10 ++--------
 1 file changed, 2 insertions(+), 8 deletions(-)

diff --git a/tools/testing/selftests/drivers/net/mlxsw/rtnetlink.sh 
b/tools/testing/selftests/drivers/net/mlxsw/rtnetlink.sh
index 893a693ad805..45a569618424 100755
--- a/tools/testing/selftests/drivers/net/mlxsw/rtnetlink.sh
+++ b/tools/testing/selftests/drivers/net/mlxsw/rtnetlink.sh
@@ -186,10 +186,7 @@ bridge_vlan_flags_test()
 
        # If we did not handle references correctly, then this should produce a
        # trace
-       devlink dev reload "$DEVLINK_DEV"
-
-       # Allow netdevices to be re-created following the reload
-       sleep 20
+       devlink_reload
 
        log_test "bridge vlan flags"
 }
@@ -923,12 +920,9 @@ devlink_reload_test()
        # devlink reload can be performed without errors
        RET=0
 
-       devlink dev reload "$DEVLINK_DEV"
-       check_err $? "devlink reload failed"
+       devlink_reload
 
        log_test "devlink reload - last test"
-
-       sleep 20
 }
 
 trap cleanup EXIT
-- 
2.45.0


Reply via email to