On Fri, 23 Aug 2024 01:48:30 -0400 David Hunter wrote:
> Subject: [PATCH 1/1 V2] Selftests: net: Improve missing modules error message
don't capitalize the prefix
> The error message descirbing the required modules is inaccurate.
spellcheck the commit message, please
> Currently, only "SKIP: Need act_mirred module" is printed when any of
> the modules are missing. As a result, users might only include that
> module; however, three modules are required.
> needed_mods="act_mirred cls_flower sch_ingress"
> +mods_missing=""
> +numb_mods_needed=0;
trailing semicolon
> +
> for mod in $needed_mods; do
> - modinfo $mod &>/dev/null || { echo "SKIP: Need act_mirred module"; exit
> $ksft_skip; }
> + modinfo $mod &>/dev/null ||
> + { mods_missing="$mods_missing$mod " ; numb_mods_needed=$(expr
> $numb_mods_needed + 1);}
this is getting too long, use a "&& continue" instead of ||
> done
>
> +if [[ $numb_mods_needed>0 ]]; then
no need to use [[]], -gt
> + echo "SKIP: $numb_mods_needed modules needed: $mods_missing" ; exit
> $ksft_skip;
why single line with semicolons, it can be two lines
> +fi
> +
> +
--
pw-bot: cr
