On 09/07/2024 11:45, Geliang Tang wrote:
> From: Geliang Tang <tanggeli...@kylinos.cn>
>
> If bpf_object__load() fails in test_xdp_adjust_frags_tail_grow(), "obj"
> opened before this should be closed. So use "goto out" to close it instead
> of using "return" here.
>
> Signed-off-by: Geliang Tang <tanggeli...@kylinos.cn>
Reviewed-by: Alan Maguire <alan.magu...@oracle.com>
...with one suggestion below...
> ---
> tools/testing/selftests/bpf/prog_tests/xdp_adjust_tail.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/bpf/prog_tests/xdp_adjust_tail.c
> b/tools/testing/selftests/bpf/prog_tests/xdp_adjust_tail.c
> index f09505f8b038..53d6ad8c2257 100644
> --- a/tools/testing/selftests/bpf/prog_tests/xdp_adjust_tail.c
> +++ b/tools/testing/selftests/bpf/prog_tests/xdp_adjust_tail.c
> @@ -222,7 +222,7 @@ static void test_xdp_adjust_frags_tail_grow(void)
>
> prog = bpf_object__next_program(obj, NULL);
> if (bpf_object__load(obj))
> - return;
> + goto out;
>
Nit: perhaps we should change this to
if (!ASSERT_OK(bpf_object__load(obj), "obj_load"))
goto out;
?
