[PATCH bpf-next v11 8/9] selftests/bpf: Use connect_fd_to_addr_str in sk_lookup

[Geliang Tang]

From: Geliang Tang <tanggeli...@kylinos.cn>

This patch uses the new helper connect_fd_to_addr_str() in make_client()
instead of using local defined function make_socket() + connect(). This
local function can be dropped latter.

A new parameter "expect_errno" is added for make_client() too to allow
different "expect_errno" is passed to make_client(). It is used to check
with "errno" after invoking connect_fd_to_addr_str().

Signed-off-by: Geliang Tang <tanggeli...@kylinos.cn>
---
 .../testing/selftests/bpf/prog_tests/sk_lookup.c | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/tools/testing/selftests/bpf/prog_tests/sk_lookup.c 
b/tools/testing/selftests/bpf/prog_tests/sk_lookup.c
index ad3f943cc2bd..26a1c339492e 100644
--- a/tools/testing/selftests/bpf/prog_tests/sk_lookup.c
+++ b/tools/testing/selftests/bpf/prog_tests/sk_lookup.c
@@ -229,17 +229,17 @@ static int make_server(int sotype, const char *ip, int 
port,
        return -1;
 }
 
-static int make_client(int sotype, const char *ip, int port)
+static int make_client(int sotype, const char *ip, int port, int expect_errno)
 {
-       struct sockaddr_storage addr = {0};
+       int family = is_ipv6(ip) ? AF_INET6 : AF_INET;
        int err, fd;
 
-       fd = make_socket(sotype, ip, port, &addr);
+       fd = socket(family, sotype, 0);
        if (fd < 0)
                return -1;
 
-       err = connect(fd, (void *)&addr, inetaddr_len(&addr));
-       if (CHECK(err, "make_client", "connect")) {
+       err = connect_fd_to_addr_str(fd, family, sotype, ip, port, NULL);
+       if (CHECK(err && (!expect_errno || errno != expect_errno), 
"make_client", "connect")) {
                log_err("failed to connect client socket");
                goto fail;
        }
@@ -645,7 +645,7 @@ static void run_lookup_prog(const struct test *t)
                        goto close;
        }
 
-       client_fd = make_client(t->sotype, t->connect_to.ip, 
t->connect_to.port);
+       client_fd = make_client(t->sotype, t->connect_to.ip, 
t->connect_to.port, 0);
        if (client_fd < 0)
                goto close;
 
@@ -1151,7 +1151,7 @@ static void run_sk_assign_connected(struct test_sk_lookup 
*skel,
        if (server_fd < 0)
                return;
 
-       connected_fd = make_client(sotype, EXT_IP4, EXT_PORT);
+       connected_fd = make_client(sotype, EXT_IP4, EXT_PORT, 0);
        if (connected_fd < 0)
                goto out_close_server;
 
@@ -1165,7 +1165,7 @@ static void run_sk_assign_connected(struct test_sk_lookup 
*skel,
                goto out_close_connected;
 
        /* Try to redirect TCP SYN / UDP packet to a connected socket */
-       client_fd = make_client(sotype, EXT_IP4, EXT_PORT);
+       client_fd = make_client(sotype, EXT_IP4, EXT_PORT, 0);
        if (client_fd < 0)
                goto out_unlink_prog;
        if (sotype == SOCK_DGRAM) {
-- 
2.43.0