On Fri, May 31, 2024 at 06:45:34PM -0700, John Hubbard wrote: > gcc requires -static-libasan in order to ensure that Address Sanitizer's > library is the first one loaded. However, this leads to build failures > on clang, when building via: > > make LLVM=1 -C tools/testing/selftests > > However, clang already does the right thing by default: it statically > links the Address Sanitizer if -fsanitize is specified. Therefore, > simply omit -static-libasan for clang builds. And leave behind a > comment, because the whole reason for static linking might not be > obvious. > > Cc: Ryan Roberts <[email protected]> > Signed-off-by: John Hubbard <[email protected]>
Assuming that $(LLVM) is the correct conditional to test for: Reviewed-by: Nathan Chancellor <[email protected]> > --- > tools/testing/selftests/fchmodat2/Makefile | 11 ++++++++++- > 1 file changed, 10 insertions(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/fchmodat2/Makefile > b/tools/testing/selftests/fchmodat2/Makefile > index 71ec34bf1501..4373cea79b79 100644 > --- a/tools/testing/selftests/fchmodat2/Makefile > +++ b/tools/testing/selftests/fchmodat2/Makefile > @@ -1,6 +1,15 @@ > # SPDX-License-Identifier: GPL-2.0-or-later > > -CFLAGS += -Wall -O2 -g -fsanitize=address -fsanitize=undefined > -static-libasan $(KHDR_INCLUDES) > +CFLAGS += -Wall -O2 -g -fsanitize=address -fsanitize=undefined > $(KHDR_INCLUDES) > + > +# gcc requires -static-libasan in order to ensure that Address Sanitizer's > +# library is the first one loaded. However, clang already statically links > the > +# Address Sanitizer if -fsanitize is specified. Therefore, simply omit > +# -static-libasan for clang builds. > +ifeq ($(LLVM),) > + CFLAGS += -static-libasan > +endif > + > TEST_GEN_PROGS := fchmodat2_test > > include ../lib.mk > -- > 2.45.1 > >
