Hi Ilpo, On 9/15/2023 8:44 AM, Ilpo Järvinen wrote: > Feature check in validate_resctrl_feature_request() takes in the test > name string and maps that to what to check per test. > > Pass resource and feature names to validate_resctrl_feature_request() > directly rather than deriving them from the test name inside the > function which makes the feature check easier to extend for new test > cases. > > Use !! in the return statement to make the boolean conversion more > obvious even if it is not strictly necessary from correctness point of > view (to avoid it looking like the function is returning a freed > pointer). > > Signed-off-by: Ilpo Järvinen <ilpo.jarvi...@linux.intel.com> > Cc: <sta...@vger.kernel.org> # selftests/resctrl: Remove duplicate feature > check from CMT test > Cc: <sta...@vger.kernel.org> # selftests/resctrl: Move _GNU_SOURCE define > into Makefile
Thank you. Reviewed-by: Reinette Chatre <reinette.cha...@intel.com> Reinette
