On Fri, 22 Sept 2023 at 15:11, 'Jinjie Ruan' via KUnit Development
<kunit-...@googlegroups.com> wrote:
>
> If the outer layer for loop is iterated more than once and it fails not
> in the first iteration, the copy pointer has been moved. So it should free
> the original copy's backup copy_start.
>
> Fixes: abbf73816b6f ("kunit: fix possible memory leak in
> kunit_filter_suites()")
> Signed-off-by: Jinjie Ruan <ruanjin...@huawei.com>
> Reviewed-by: Rae Moar <rm...@google.com>
> ---
> v2:
> - Add Reviewed-by.
> ---Like v2, this looks good. Reviewed-by: David Gow <david...@google.com> Cheers, -- David > lib/kunit/executor.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/kunit/executor.c b/lib/kunit/executor.c > index a037a46fae5e..9358ed2df839 100644 > --- a/lib/kunit/executor.c > +++ b/lib/kunit/executor.c > @@ -243,7 +243,7 @@ kunit_filter_suites(const struct kunit_suite_set > *suite_set, > > free_copy: > if (*err) > - kfree(copy); > + kfree(copy_start); > > return filtered; > } > -- > 2.34.1 > > -- > You received this message because you are subscribed to the Google Groups > "KUnit Development" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to kunit-dev+unsubscr...@googlegroups.com. > To view this discussion on the web visit > https://groups.google.com/d/msgid/kunit-dev/20230922071020.2554677-3-ruanjinjie%40huawei.com.
smime.p7s
Description: S/MIME Cryptographic Signature
