On Sun, Oct 18, 2015 at 05:02:55AM +0200, Peter Hüwe wrote: > Am Freitag, 16. Oktober 2015, 20:40:20 schrieb Jarkko Sakkinen: > > + pa = ((u64) le32_to_cpu(ioread32(&priv->cca->cmd_pa_high)) << 32) + > > + (u64) le32_to_cpu(ioread32(&priv->cca->cmd_pa_low)); > > The canonical form would be > > + pa = ((u64) le32_to_cpu(ioread32(&priv->cca->cmd_pa_high)) << 32) | > > + (u64) le32_to_cpu(ioread32(&priv->cca->cmd_pa_low)); > ? > Or am I missing something? > Shall I fix-up?
Please do. Current works but definitely your form is correct. > Thanks, > Peter /Jarkko -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/