On Thu, Oct 15, 2015 at 7:41 PM, Oleg Nesterov <o...@redhat.com> wrote: > OOH ;) I'll try to look at this patch and the changes in the generic > code later. A couple of nits right now. > > Please CC x86 maintainers, not only x...@kernel.org. > > Please do not remove get/put_user_ex from this code. And this reminds > me that we can improve *user_try/*user_catch ... > > [...snip...] > > the rest looks unreviewable because you didn't split it and because > you removed try/catch ;) The same for copy-from-user. > > Please help us to understand these changes and make the more reviewable > patches if possible. Personally I think you have a point.
What I did here was replace the old x86-specific version with the generic version, which I then modified to support x32. If you compare it with the generic version, the only difference is the addition of the ia32 flag. The intent was to make it as close as possible to the generic version, which makes it easier to update both at the same time when a new siginfo_t fields is added. This is also why I didn't use put_user_try/get_user_try: it would make the x86 version unnecessarily diverge from the generic version, since those macros only exist in the x86 architecture. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
