On 10/15/2015 9:00 AM, Bjorn Helgaas wrote: > On Tue, Oct 13, 2015 at 11:00:31PM +0200, Arnd Bergmann wrote: >> On Tuesday 13 October 2015 13:11:34 Ray Jui wrote: >>>>> diff --git a/drivers/pci/host/pcie-iproc.c b/drivers/pci/host/pcie-iproc.c >>>>> index f3481ddff344..abcb4be2ee19 100644 >>>>> --- a/drivers/pci/host/pcie-iproc.c >>>>> +++ b/drivers/pci/host/pcie-iproc.c >>>>> @@ -235,12 +235,13 @@ static void iproc_pcie_enable(struct iproc_pcie >>>>> *pcie) >>>>> * >>>>> * axi_addr -> iproc_pcie_address -> OARR -> OMAP -> pci_address >>>>> */ >>>>> -static int iproc_pcie_setup_ob(struct iproc_pcie *pcie, u64 axi_addr, >>>>> +int iproc_pcie_setup_ob(struct iproc_pcie *pcie, u64 axi_addr, >>>> >>>> Why are you removing the static here? >>>> >>> >>> Yeah we should keep this function as static. The rest of this change >>> looks good! >>> >> >> Sorry, this accidentally ended up in the patch when I marked the >> function as global to track down how the division got called. >> >> I'll send a new version. > > Ping; I can easily fix up the static, but it'd be nice to have real acks > from Ray and Hauke. > > Bjorn >
The current patch looks good to me except that iproc_pcie_setup_ob should be kept static. With static added back: Acked-by: Ray Jui <r...@broadcom.com> Thanks, Ray -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
