On Thursday 30 November 2006 09:47, you wrote: > On Thu, 30 Nov 2006 08:12:02 +0100 > > Torsten Ertbjerg Rasmussen <[EMAIL PROTECTED]> wrote: > > The real time clocks ds1742 and ds1743 differs only in the size of the > > nvram. This patch changes the existing ds1742 driver to support also > > ds1743. The main change is that the nvram size is determined from the > > resource attached to the device. > > > > > > + pdata->ioaddr_rtc = ioaddr + pdata->size_nvram; > > > > /* turn RTC on if it was not on */ > > + ioaddr = pdata->ioaddr_rtc; > > sec = readb(ioaddr + RTC_SECONDS); > > why not > sec = readb(pdata->ioaddr_rtc + RTC_SECONDS); > ?
ioaddr is used several times below this point, so diff would be larger. In the original code, ioaddr points to beginning of nvram and RTC_SECONDS implicitly adds the nvram size. Now the nvram size is removed from RTC_SECONDS (and other RTC_*) so ioaddr must point to start of rtc-data. Regards, Torsten Rasmussen > > > Acked-by: Alessandro Zummo <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
