On 14/10/15 16:40, Jeremy Linton wrote:
On 10/14/2015 06:20 AM, Suzuki K. Poulose wrote:
diff --git a/arch/arm64/include/asm/page.h b/arch/arm64/include/asm/page.h
index da32354..736ed4c 100644
--- a/arch/arm64/include/asm/page.h
+++ b/arch/arm64/include/asm/page.h
@@ -24,6 +24,9 @@
  #ifdef CONFIG_ARM64_64K_PAGES
  #define PAGE_SHIFT        16
  #define CONT_SHIFT        5
+#elif defined(CONFIG_ARM64_16K_PAGES)
+#define PAGE_SHIFT        14
+#define CONT_SHIFT        9
  #else
  #define PAGE_SHIFT        12
  #define CONT_SHIFT        4

Suzuki,

Is CONT_SHIFT correct? I thought it should be 7? The ARM-ARM says that a 
contiguous 3rd level lookup is 128 entries.


Err, you are right. I tested it with 9 and I still got contiguous
mappings. May be because we anyway have 7 contiguous bits and the
kernel text is read-only. I will fix that, thanks for spotting.

Suzuki

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to