On Mon, Oct 05, 2015 at 06:02:03PM +0100, Suzuki K. Poulose wrote:
> +static bool cpus_have_hwcap(const struct arm64_cpu_capabilities *cap)
> +{
> + switch(cap->hwcap_type) {
> + case CAP_HWCAP:
> + return !!(elf_hwcap & cap->hwcap);
> +#ifdef CONFIG_COMPAT
> + case CAP_COMPAT_HWCAP:
> + return !!(compat_elf_hwcap & (u32)cap->hwcap);
> + case CAP_COMPAT_HWCAP2:
> + return !!(compat_elf_hwcap2 & (u32)cap->hwcap);
> +#endif
> + default:
> + BUG();
> + return false;
> + }
> +}
Apart from the multiple returns, you don't really need !! since the
return type is bool already.
--
Catalin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
