Gregory, 2015-10-06 16:51 GMT+02:00 Gregory CLEMENT <gregory.clement >> + if (of_device_is_compatible(np, "marvell,armada-380-sdhci")) >> + ret = mv_conf_mbus_windows(dev, pxa->mbus_win_regs, >> + mv_mbus_dram_info()); > > I would find it cleaner to not rely on the device tree outise the probe > function. What about just testing pxa->mbus_win_regs ? As it is set only > if we need it, it should be a good test. >
Sure, it will ease calling the function. Thanks, Marcin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
