Hello!

> This patch set adds support for Exynos SROM controller DT based driver.
> Currently SROM register sets are used only during S2R, so driver
> basically added for taking care of S2R. It will help us in removing
> static mapping from exynos.c and other extra code handline during S2R.

 Very good news, but, your driver seems not to do anything except 
suspend/resume. But how do i add
some device plugged into it? In order to be operational, its outputs have to be 
configured. But how
do i do it with your driver? For example, on SMDK boards SROM controller is 
used to connect SMSC9111
etherner chip.
 Currently i use hardcoded initialization based on of_machine_is_compatible(), 
but i believe this
would be considered a hack and such a thing cannot be pushed upstream. I guess 
i have to put all
needed configuration into device tree somehow. But how? Are there any 
recommentations?

Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to