On 5 October 2015 at 10:41, Maxime Ripard <maxime.rip...@free-electrons.com> wrote: > On Fri, Oct 02, 2015 at 07:24:20AM +0200, Code Kipper wrote: >> >> + >> >> + - compatible : should be one of the following: >> >> + - "allwinner,sun4i-a10-spdif": for the Allwinner A10 SoC >> >> + - "allwinner,sun7i-a20-spdif": for the Allwinner A20 SoC >> >> + - "allwinner,sun6i-a31-spdif": for the Allwinner A31 SoC >> > >> > Are all these compatibles really work? Is there any significant >> > difference between the controller on all these SoCs? >> >> Let us assume that there isn't any difference. Remember SPDIF details >> for all of these devices is sketchy. In the A10 User Manual, it's not >> even mentioned although devices such as the Mele A2000 which I use >> come with the physical connector. It's only when the A20 Manual was >> released that we see the pin details and related components. We didn't >> see a SPDIF block spec until the H3 User Manual was released. >> >> Looking at the SDK code I've only seen fifo level settings to be >> different for the sun6i family. It was this release that also showed >> Rx rotines. The fact of the matter is we won't know until these SoCs >> have been tested and with that in mind I'm happy to remove all >> capabilities for now until then. > > The point was more that you document compatibles that you are not > actually supporting. > > You've only tested it on one SoC (and it actually works only on one > SoC, or at least with one compatible), so only document that.
Fixed, Thanks, CK > > Maxime > > -- > Maxime Ripard, Free Electrons > Embedded Linux, Kernel and Android engineering > http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
