On Sun, Oct 4, 2015 at 4:48 AM, Theodore Ts'o <ty...@mit.edu> wrote: > On Sat, Oct 03, 2015 at 04:23:02PM +0300, Alexander Kapshuk wrote: >> 'tune2fs' is located in varying places depending on the distro. >> Current implementation output on distros where 'tune2fs' is found at >> a location that is not available in the PATH for the regular user, >> e.g. '/sbin', will have nothing to display. >> While running 'ver_linux' as user 'root' should be OK. > > Instead of making all of these changes, why not just add > > PATH=$PATH:/sbin:/usr/sbin:/bin:/usr/bin > > to the beginning of ver_linux? > > - Ted
Thanks for your feedback. My understanding is that $PATH used to be set in ver_linux before. It had been removed by the commit given below: 2008-07-31kbuild: scripts/ver_linux: don't set PATH It would have saved both a bug submitter and me a few hours if scripts/ver_linux had picked the same gcc as the build. Since I can't see any reason why it fiddles with PATH at all this patch therefore removes the PATH setting. Signed-off-by: Adrian Bunk <b...@kernel.org> Signed-off-by: Sam Ravnborg <s...@ravnborg.org> ---------------------------------------------------------------------- Perhaps a better approach would be for the user to set their $PATH appropriately in their shell environment, rather than in ver_linux, as suggested in the commentary found in ver_linux, instead of ver_linux trying to guess where the binaries are. Which effectively makes my other patch, path2bin_test.patch, redundant. Apologies for that. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
