The current implementation uses both 'grep' and 'awk' for text processing
here, which may be alright as a quick solution to be run on the command
line. While in a script, 'sed' or 'awk' would be a better choice. On
top of that, the current implementation expects the version number to
be found in the last field as seen by 'awk'. Should the output format
be different, this approach would no longer be reliable.
The proposed implementation uses 'sed' as a more flexible tool to handle
varying output formats.
Tested on:
Oracle Linux Server release 7.1
Signed-off-by: Alexander Kapshuk <alexander.kaps...@gmail.com>
---
--- linux/scripts/ver_linux.orig 2015-10-03 13:41:57.118790241 +0300
+++ linux/scripts/ver_linux 2015-10-03 13:55:01.897046697 +0300
@@ -47,8 +47,14 @@
cardmgr -V 2>&1| grep version | awk \
'NR==1{print "pcmcia-cs ", $3}'
-quota -V 2>&1 | grep version | awk \
-'NR==1{print "quota-tools ", $NF}'
+test -x "$quota" &&
+$quota -V 2>&1 |
+sed '
+ /version/!d
+ s/[^0-9\.]//g
+ s/\.$//
+ s/^/quota-tools\t\t/
+'
pppd --version 2>&1| grep version | awk \
'NR==1{print "PPP ", $3}'
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
